projects/datalad/bugs-done/regression: index.lck in shared-group is not g+wyohhttp://git-annex.branchable.com/projects/datalad/bugs-done/regression__58___index.lck_in_shared-group_is_not_g+w/git-annexikiwiki2023-01-05T17:30:31Zcomment 1http://git-annex.branchable.com/projects/datalad/bugs-done/regression__58___index.lck_in_shared-group_is_not_g+w/comment_1_7f25fd487c60f8b6fcaddd1444d898af/joey2023-01-05T17:30:31Z2021-07-12T13:42:12Z
Is datalad doing something with the new annex.freezecontent-command?
comment 2http://git-annex.branchable.com/projects/datalad/bugs-done/regression__58___index.lck_in_shared-group_is_not_g+w/comment_2_92c7a561537e0c6628f30be233b9d7f6/joey2023-01-05T17:30:31Z2021-07-12T13:46:18Z
<p>I don't think annex.freezecontent-command will affect writing this file
though.</p>
<p>This seems to be how to reproduce it:</p>
<pre><code>git config sharedRepository group
git annex init
-rw-rw-r-- 1 joey joey 137 Jul 12 09:53 .git/annex/index
-rw-r--r-- 1 joey joey 41 Jul 12 09:53 .git/annex/index.lck
</code></pre>
<p>Not identical modes here, but with an older git-annex the index.lck is 664
not 644.</p>
<p>Also, for some reason git-annex init with that config set complains that
"Filesystem allows writing to files whose write bit is not set."
And enters an adjusted brach. The older git-annex didn't do that either.</p>
comment 3http://git-annex.branchable.com/projects/datalad/bugs-done/regression__58___index.lck_in_shared-group_is_not_g+w/comment_3_621beade26a1dbbdea000ca43d93a325/joey2023-01-05T17:30:31Z2021-07-12T14:09:19Z
<p>Fixed the problem with git-annex init's probing.</p>
<p>Oh, that's odd, fixing that also fixed the index.lck permissions.</p>
<p>So, the actual cause of the permissions problem is init deciding to enter
an adjusted unlocked branch. Entering the branch after init does not result
in the problem though. So still need to track down what's happening there,
since it can enter the adjusted branch for other reasons.</p>
comment 4http://git-annex.branchable.com/projects/datalad/bugs-done/regression__58___index.lck_in_shared-group_is_not_g+w/comment_4_3b19a1d3e0e13e407af476b54b725bd1/joey2023-01-05T17:30:31Z2021-07-12T14:41:50Z
<p>The bug was making init set annex.crippledfilesystem,
and once that's set, git-annex avoids setting file
perms, so then it writes index.lck it leaves it at the default permissions.</p>
<p>That might or might not be a problem in some case (eg if some filesystem
was detected as crippled but still supported file permissions to a point
that write bits need to be added to support core.sharedRepository = group), but
the reversion was fixed by fixing init's behavior. So, closing this.</p>
comment 5http://git-annex.branchable.com/projects/datalad/bugs-done/regression__58___index.lck_in_shared-group_is_not_g+w/comment_5_0655ad5ece1ccd1892ea217aac493594/yarikoptic2023-01-05T17:30:31Z2021-07-12T17:44:58Z
FWIW FTR: the fix (will check on datalad side with the next cron build) is likely the <a href="https://git.kitenet.net/index.cgi/git-annex.git/commit/?id=6a581f8b8b54719f2c34fdeb071e546d9a8f64c9">8.20210630-52-g6a581f8b8</a> (I still don't know how to navigate from the <code>[fixed]</code> tag to actual fix/version)
comment 6http://git-annex.branchable.com/projects/datalad/bugs-done/regression__58___index.lck_in_shared-group_is_not_g+w/comment_6_9dce3bf28e416dbcc08b314dbc08c8a4/joey2023-01-05T17:30:31Z2021-07-12T20:00:32Z
<p>Yes that's the commit. Normally I'd have closed it in the commit but I
didn't realize at that point that the commit actually fixed it.</p>