Please describe the problem.
Annexing files can fail with "Invalid argument" error. It appears to be an interaction of filesystem and file name. The file name is lh.aparc.DKTatlas.annot
/rh.aparc.DKTatlas.annot
, and the filesystem is:
$ mount | grep data
/dev/mapper/bitlocker on /data type fuseblk (rw,nosuid,nodev,relatime,user_id=0,group_id=0,default_permissions,allow_other,blksize=4096)
$ ntfs-3g
ntfs-3g: No device is specified.
ntfs-3g 2021.8.22 integrated FUSE 28 - Third Generation NTFS Driver
Configuration type 7, XATTRS are on, POSIX ACLS are on
However, formatting a file as NTFS and mounting as loop to make a minimal reproduction allowed the operation to succeed.
What steps will reproduce the problem?
I am able to reproduce this problem reliably on the filesystem above:
$ git init test/
$ cd test
$ git annex init
$ curl -sSL https://file.io/ZtE5ivep7E9V -o lh.aparc.DKTatlas.annot
$ git annex add lh.aparc.DKTatlas.annot
add lh.aparc.DKTatlas.annot
.git/annex/othertmp/: openTempFile template ingest-lh.: invalid argument (Invalid argument)
failed
add: 1 failed
However, renaming the file to L.annot
, annexing it, and git mv
ing it back works, so I am not stuck adding the file contents directly to git.
I hope the log below will give you a hint of what's going on, as I regret I am unable to reproduce this on other filesystems.
What version of git-annex are you using? On what operating system?
OS: Ubuntu 22.04.3 LTS
git-annex version: 10.20230408-g5b1e8ba77
build flags: Assistant Webapp Pairing Inotify DBus DesktopNotify TorrentParser MagicMime Benchmark Feeds Testsuite S3 WebDAV
dependency versions: aws-0.22.1 bloomfilter-2.0.1.0 cryptonite-0.29 DAV-1.3.4 feed-1.3.2.1 ghc-9.0.2 http-client-0.7.13.1 persistent-sqlite-2.13.1.0 torrent-10000.1.1 uuid-1.3.15 yesod-1.6.2.1
key/value backends: SHA256E SHA256 SHA512E SHA512 SHA224E SHA224 SHA384E SHA384 SHA3_256E SHA3_256 SHA3_512E SHA3_512 SHA3_224E SHA3_224 SHA3_384E SHA3_384 SKEIN256E SKEIN256 SKEIN512E SKEIN512 BLAKE2B256E BLAKE2B256 BLAKE2B512E BLAKE2B512 BLAKE2B160E BLAKE2B160 BLAKE2B224E BLAKE2B224 BLAKE2B384E BLAKE2B384 BLAKE2BP512E BLAKE2BP512 BLAKE2S256E BLAKE2S256 BLAKE2S160E BLAKE2S160 BLAKE2S224E BLAKE2S224 BLAKE2SP256E BLAKE2SP256 BLAKE2SP224E BLAKE2SP224 SHA1E SHA1 MD5E MD5 WORM URL X*
remote types: git gcrypt p2p S3 bup directory rsync web bittorrent webdav adb tahoe glacier ddar git-lfs httpalso borg hook external
operating system: linux x86_64
supported repository versions: 8 9 10
upgrade supported from repository versions: 0 1 2 3 4 5 6 7 8 9 10
local repository version: 10
Please provide any additional information below.
$ git annex add -d lh.aparc.DKTatlas.annot
[2023-12-05 09:40:20.256526552] (Utility.Process) process [1162202] read: git ["--git-dir=.git","--work-tree=.","--literal-pathspecs","-c","annex.debug=true","show-ref","git-annex"]
[2023-12-05 09:40:20.260613884] (Utility.Process) process [1162202] done ExitSuccess
[2023-12-05 09:40:20.260892906] (Utility.Process) process [1162203] read: git ["--git-dir=.git","--work-tree=.","--literal-pathspecs","-c","annex.debug=true","show-ref","--hash","refs/heads/git-annex"]
[2023-12-05 09:40:20.265019085] (Utility.Process) process [1162203] done ExitSuccess
[2023-12-05 09:40:20.265446352] (Utility.Process) process [1162204] read: git ["--git-dir=.git","--work-tree=.","--literal-pathspecs","-c","annex.debug=true","log","refs/heads/git-annex..eb539b816feb00e6be3a252d36efaa7426eccca1","--pretty=%H","-n1"]
[2023-12-05 09:40:20.270301207] (Utility.Process) process [1162204] done ExitSuccess
[2023-12-05 09:40:20.271251091] (Utility.Process) process [1162205] chat: git ["--git-dir=.git","--work-tree=.","--literal-pathspecs","-c","annex.debug=true","cat-file","--batch"]
[2023-12-05 09:40:20.275373234] (Utility.Process) process [1162206] read: git ["--git-dir=.git","--work-tree=.","--literal-pathspecs","-c","annex.debug=true","symbolic-ref","-q","HEAD"]
[2023-12-05 09:40:20.278672692] (Utility.Process) process [1162206] done ExitSuccess
[2023-12-05 09:40:20.278946202] (Utility.Process) process [1162207] read: git ["--git-dir=.git","--work-tree=.","--literal-pathspecs","-c","annex.debug=true","show-ref","refs/heads/master"]
[2023-12-05 09:40:20.282475944] (Utility.Process) process [1162207] done ExitFailure 1
[2023-12-05 09:40:20.282779905] (Utility.Process) process [1162208] read: git ["--git-dir=.git","--work-tree=.","--literal-pathspecs","-c","annex.debug=true","ls-files","-z","--others","--exclude-standard","--","lh.aparc.DKTatlas.annot"]
[2023-12-05 09:40:20.286209985] (Utility.Process) process [1162209] chat: git ["--git-dir=.git","--work-tree=.","--literal-pathspecs","-c","annex.debug=true","check-attr","-z","--stdin","annex.backend","annex.largefiles","annex.numcopies","annex.mincopies","--"]
[2023-12-05 09:40:20.28954558] (Utility.Process) process [1162210] chat: git ["--git-dir=.git","--work-tree=.","--literal-pathspecs","-c","annex.debug=true","cat-file","--batch-check=%(objectname) %(objecttype) %(objectsize)"]
add lh.aparc.DKTatlas.annot [2023-12-05 09:40:20.293105736] (Utility.Process) process [1162211] read: git ["--git-dir=.git","--work-tree=.","--literal-pathspecs","-c","annex.debug=true","symbolic-ref","-q","HEAD"]
[2023-12-05 09:40:20.296109063] (Utility.Process) process [1162211] done ExitSuccess
[2023-12-05 09:40:20.296268327] (Utility.Process) process [1162212] read: git ["--git-dir=.git","--work-tree=.","--literal-pathspecs","-c","annex.debug=true","show-ref","refs/heads/master"]
[2023-12-05 09:40:20.299447211] (Utility.Process) process [1162212] done ExitFailure 1
[2023-12-05 09:40:20.299472144] (Annex.Perms) freezing content lh.aparc.DKTatlas.annot
.git/annex/othertmp/: openTempFile template ingest-lh.: invalid argument (Invalid argument)
failed
[2023-12-05 09:40:20.299683526] (Utility.Process) process [1162208] done ExitSuccess
[2023-12-05 09:40:20.299804817] (Utility.Process) process [1162213] read: git ["--git-dir=.git","--work-tree=.","--literal-pathspecs","-c","annex.debug=true","ls-files","-z","--modified","--","lh.aparc.DKTatlas.annot"]
[2023-12-05 09:40:20.302582841] (Utility.Process) process [1162213] done ExitSuccess
[2023-12-05 09:40:20.302707305] (Utility.Process) process [1162214] read: git ["--git-dir=.git","--work-tree=.","--literal-pathspecs","-c","annex.debug=true","diff","--name-only","--diff-filter=T","-z","--cached","--","lh.aparc.DKTatlas.annot"]
[2023-12-05 09:40:20.30608269] (Utility.Process) process [1162214] done ExitSuccess
[2023-12-05 09:40:20.306609675] (Utility.Process) process [1162205] done ExitSuccess
[2023-12-05 09:40:20.306732757] (Utility.Process) process [1162210] done ExitSuccess
[2023-12-05 09:40:20.306873108] (Utility.Process) process [1162209] done ExitSuccess
add: 1 failed
Have you had any luck using git-annex before? (Sometimes we get tired of reading bug reports all day and a lil' positive end note does wonders)
Yes! I use git annex and datalad all the time for personal and work projects.
This is EINVAL from probably open(2) or something like that.
The problem is likely the ending ".", since FAT and probably other Microsoft filesystems don't allow that, and/or have other strange behavior like silently removing that.
Changed the code to avoid this.