We have received a request to enable Servant for the NeuroDebian builds of git-annex. ATM by default it is not enabled
Flag Servant
Description: Use the servant library, enabling using annex+http urls and git-annex p2phttp
before I patch it, I thought to ask if it is "safe" as would it cause any possible side-effects, or why it is not enabled by default? (unclear from description)
Thanks in advance for the clarification
Yes, it's safe to enable this build flag. It makes the
git-annex p2phttpcommand work, but users still have to choose to run that server.The only reason it's a build flag is that the version of servant needed is not available in some old build environments. The flag actually should be enabled by default when the necessary dependencies are installable (in the case of a cabal build) or installed (in Debian's case).
you do have servant libraries in debian/control and they are present but the build we are getting is lacking Servant support:
where is the catch or did I misunderstand you statement?
If you are building on debian stable the issue is probably the version of stm bundled with ghc being too old. This build flag needs stm 2.5.1 (also warp 3.2.8 and warp-tls 3.2.2)
I've applied a patch that will let the build flag work with older versions of stm (commit 3a53c6012101dcb76786ee497ca4223a8e28ceab).
tried, FTBFS
it is building within
docker://datalad/buildenv-git-annexwhich is built using bookworm frozen to 20230829T151102Z via snapshots repo.Ah, missed that call site. Fixed in b83fdf66dfe4caf52c097af8773d8f7470e48b5e